Commit f2da6559 authored by Mattias J Duffy's avatar Mattias J Duffy
Browse files

cleaning out master

parent 6e818728
# Editor configuration, see
root = true
charset = utf-8
indent_style = tabs
indent_size = 4
insert_final_newline = true
trim_trailing_whitespace = true
max_line_length = off
trim_trailing_whitespace = false
# See for more about ignoring files.
# compiled output
# dependencies
# IDEs and editors
# IDE - VSCode
# misc
# e2e
#System Files
#random stuff
\ No newline at end of file
"vsicons.presets.angular": true
\ No newline at end of file
# Contributor Code of Conduct
## Version 0.3a-angular
As contributors and maintainers of the What's Open project, we pledge to respect everyone who contributes by posting issues, updating documentation, submitting pull requests, providing feedback in comments, and any other activities.
Communication through any of What's Open's channels (GitLab, IRC, mailing lists, Google+, Twitter, etc.) must be constructive and never resort to personal attacks, trolling, public or private harrassment, insults, or other unprofessional conduct.
We promise to extend courtesy and respect to everyone involved in this project regardless of gender, gender identity, sexual orientation, disability, age, race, ethnicity, religion, or level of experience. We expect anyone contributing to the Angular project to do the same.
If any member of the community violates this code of conduct, the maintainers of the Angular project may take action, removing issues, comments, and PRs or blocking accounts as deemed appropriate.
If you are subject to or witness unacceptable behavior, or have any other concerns, please email us at [](
# Contributing to What's Open Web
We would love for you to contribute to What's Open and help make it even better than it is
today! As a contributor, here are the guidelines we would like you to follow:
- [Code of Conduct](#coc)
- [Question or Problem?](#question)
- [Issues and Bugs](#issue)
- [Feature Requests](#feature)
- [Submission Guidelines](#submit)
- [Coding Rules](#rules)
- [Commit Message Guidelines](#commit)
## <a name="coc"></a> Code of Conduct
Help us keep What's Open open and inclusive. Please read and follow our [Code of Conduct][coc].
## <a name="question"></a> Got a Question or Problem?
Please, do not open issues for the general support questions as we want to keep GitLab issues for bug reports and feature requests. You've got much better chances of getting your question answered on [Slack Group][slack] where questions should be asked in their respective channels.
## <a name="issue"></a> Found a Bug?
If you find a bug in the source code, you can help us by
[submitting an issue](#submit-issue) to our [GitLab Repository][gitlab]. Even better, you can
[submit a Merge Request](#submit-pr) with a fix.
## <a name="feature"></a> Missing a Feature?
You can *request* a new feature by [submitting an issue](#submit-issue) to our GitLab
Repository. If you would like to *implement* a new feature, please submit an issue with
a proposal for your work first, to be sure that we can use it.
Please consider what kind of change it is:
* For a **Major Feature**, first open an issue and outline your proposal so that it can be
discussed. This will also allow us to better coordinate our efforts, prevent duplication of work,
and help you to craft the change so that it is successfully accepted into the project.
* **Small Features** can be crafted and directly [submitted as a Merge Request](#submit-pr).
## <a name="submit"></a> Submission Guidelines
### <a name="submit-issue"></a> Submitting an Issue
Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.
We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs we will systematically ask you to provide a minimal reproduction scenario using Having a live, reproducible scenario gives us wealth of important information without going back & forth to you with additional questions like:
- version of Angular used
- 3rd-party libraries and their versions
- and most importantly - a use-case that fails
A minimal reproduce scenario using allows us to quickly confirm a bug (or point out coding problem) as well as confirm that we are fixing the right problem. If plunker is not a suitable way to demonstrate the problem (for example for issues related to our npm packaging), please create a standalone git repository demonstrating the problem.
We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. Interestingly, from our experience users often find coding problems themselves while preparing a minimal plunk. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.
Unfortunately we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that don't have enough info to be reproduced.
You can file new issues by filling out our [new issue form][new-issue].
### <a name="submit-pr"></a> Submitting a Merge Request (PR)
Before you submit your Merge Request (MR) consider the following guidelines:
* Search [GitLab][merge-request] for an open or closed PR
that relates to your submission. You don't want to duplicate effort.
* Make your changes in a new git branch:
git checkout -b my-fix-branch master
* Create your patch, **including appropriate test cases**.
* Follow our [Coding Rules](#rules).
* Run the full Angular test suite, as described in the [developer documentation][dev-doc],
and ensure that all tests pass.
* Commit your changes using a descriptive commit message that follows our
[commit message conventions](#commit). Adherence to these conventions
is necessary because release notes are automatically generated from these messages.
git commit -a
Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
* h your branch to GitLab:
git push origin my-fix-branch
* In GitLab, send a merge request to `master`.
* If we suggest changes then:
* Make the required updates.
* Re-run the Angular test suites to ensure tests are still passing.
* Rebase your branch and force push to your GitLab repository (this will update your Merge Request):
git rebase master -i
git push -f
That's it! Thank you for your contribution!
#### After your merge request is merged
After your merge request is merged, you can safely delete your branch and merge the changes
from the main (upstream) repository:
* Delete the remote branch on GitLab either through the GitLab web UI or your local shell as follows:
git push origin --delete my-fix-branch
* Check out the master branch:
git checkout master -f
* Delete the local branch:
git branch -D my-fix-branch
* Update your master with the latest upstream version:
git l --ff upstream master
## <a name="rules"></a> Coding Rules
To ensure consistency throughout the source code, keep these rules in mind as you are working:
* All features or bug fixes **must be tested** by one or more specs (unit-tests).
* All lic API methods **must be documented**. (Details TBC).
* We follow [Angular's Style Guide][style-guide], but wrap all code at
**100 characters**. An automated formatter is available, see
## <a name="commit"></a> Commit Message Guidelines
We have very precise rules over how our git commit messages can be formatted. This leads to **more
readable messages** that are easy to follow when looking through the **project history**. But also,
we use the git commit messages to **generate the Angular change log**.
### Commit Message Format
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
format that includes a **type**, a **scope** and a **subject**:
<type>(<scope>): <subject>
The **header** is mandatory and the **scope** of the header is optional.
Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
to read on GitLab as well as in various git tools.
Footer should contain a [closing reference to an issue]( if any.
Samples: (even more [samples](
docs(changelog): update change log to beta.5
fix(release): need to depend on latest rxjs and zone.js
The version in our package.json gets copied to the one we lish, and users need the latest of these.
### Revert
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit. In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.
### Type
Must be one of the following:
* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
* **ci**: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
* **docs**: Documentation only changes
* **feat**: A new feature
* **fix**: A bug fix
* **perf**: A code change that improves performance
* **refactor**: A code change that neither fixes a bug nor adds a feature
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing
semi-colons, etc)
* **test**: Adding missing tests or correcting existing tests
### Scope
The scope should be the name of the compont/pipe/service affected (as perceived by person reading changelog generated from commit messages.
Examples are:
* **filter-bar**
* **component-bar**
* **safe-url**
There is currently few exception to the "use package name" rule:
* **packaging**: used for changes that change the npm package layout in all of our packages, e.g. lic path changes, package.json changes done to all packages, d.ts file/format changes, changes to bundles, etc.
* **changelog**: used for updating the release notes in
* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all packages (e.g. `style: add missing semicolons`)
### Subject
The subject contains succinct description of the change:
* use the imperative, present tense: "change" not "changed" nor "changes"
* don't capitalize first letter
* no dot (.) at the end
### Body
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
The body should include the motivation for the change and contrast this with previous behavior.
### Footer
The footer should contain any information about **Breaking Changes** and is also the place to
reference GitLab issues that this commit **Closes**.
**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.
A detailed explanation can be found in this [document][commit-message-format].
\ No newline at end of file
# WhatsOpenA2
This project was generated with [angular-cli]( version 1.0.0-beta.28.3.
## Development server
Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files.
## Code scaffolding
Run `ng generate component component-name` to generate a new component. You can also use `ng generate directive/pipe/service/class/module`.
## Build
Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory. Use the `-prod` flag for a production build.
## Running unit tests
Run `ng test` to execute the unit tests via [Karma](
## Running end-to-end tests
Run `ng e2e` to execute the end-to-end tests via [Protractor](
Before running the tests make sure you are serving the app via `ng serve`.
## Deploying to GitHub Pages
Run `ng github-pages:deploy` to deploy to GitHub Pages.
## Further help
To get more help on the `angular-cli` use `ng help` or go check out the [Angular-CLI README](
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
"project": {
"version": "1.0.0-rc.4",
"name": "whats-open-web"
"apps": [
"root": "src",
"outDir": "dist",
"assets": [
"index": "index.html",
"main": "main.ts",
"polyfills": "polyfills.ts",
"test": "test.ts",
"tsconfig": "tsconfig.json",
"prefix": "app",
"styles": [
"scripts": [
"environmentSource": "environments/environment.ts",
"environments": {
"dev": "environments/environment.ts",
"prod": "environments/"
"e2e": {
"protractor": {
"config": "./protractor.conf.js"
"lint": [
"files": "src/**/*.ts",
"project": "src/tsconfig.json"
"files": "e2e/**/*.ts",
"project": "e2e/tsconfig.json"
"test": {
"karma": {
"config": "./karma.conf.js"
"defaults": {
"styleExt": "scss",
"prefixInterfaces": false,
"inline": {
"style": false,
"template": false
"spec": {
"class": false,
"component": true,
"directive": true,
"module": false,
"pipe": true,
"service": true
import { WhatsOpenA2Page } from './app.po';
describe('whats-open-a2 App', function() {
let page: WhatsOpenA2Page;
beforeEach(() => {
page = new WhatsOpenA2Page();
it('should display message saying app works', () => {
expect(page.getParagraphText()).toEqual('app works!');
import { browser, element, by } from 'protractor';
export class WhatsOpenA2Page {
navigateTo() {
return browser.get('/');
getParagraphText() {
return element(by.css('app-root h1')).getText();
"compileOnSave": false,
"compilerOptions": {
"declaration": false,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"module": "commonjs",
"moduleResolution": "node",
"outDir": "../dist/out-tsc-e2e",
"sourceMap": true,
"target": "es5",
"typeRoots": [
// Karma configuration file, see link for more information
module.exports = function (config) {
basePath: '',
frameworks: ['jasmine', 'angular-cli'],
plugins: [
files: [
{ pattern: './src/test.ts', watched: false }
preprocessors: {
'./src/test.ts': ['angular-cli']
mime: {
'text/x-typescript': ['ts','tsx']
remapIstanbulReporter: {
reports: {
html: 'coverage',
lcovonly: './coverage/coverage.lcov'
angularCli: {
config: './angular-cli.json',
environment: 'dev'
reporters: config.angularCli && config.angularCli.codeCoverage
? ['progress', 'karma-remap-istanbul']
: ['progress'],
port: 9876,
colors: true,
logLevel: config.LOG_INFO,
autoWatch: true,
browsers: ['Chrome'],
singleRun: false
"name": "whats-open-web",
"version": "0.0.0",
"license": "MIT",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
"private": true,
"dependencies": {
"@angular/common": "^4.0.0",
"@angular/compiler": "^4.0.0",
"@angular/core": "^4.0.0",
"@angular/forms": "^4.0.0",
"@angular/http": "^4.0.0",
"@angular/platform-browser": "^4.0.0",
"@angular/platform-browser-dynamic": "^4.0.0",
"@angular/router": "^4.0.0",
"core-js": "^2.4.1",
"rxjs": "^5.1.0",
"zone.js": "^0.8.4"
"devDependencies": {
"@angular/cli": "1.0.0",
"@angular/compiler-cli": "^4.0.0",
"@types/jasmine": "2.5.38",
"@types/node": "~6.0.60",
"codelyzer": "~2.0.0",
"jasmine-core": "~2.5.2",
"jasmine-spec-reporter": "~3.2.0",
"karma": "~1.4.1",
"karma-chrome-launcher": "~2.0.0",
"karma-cli": "~1.0.1",
"karma-jasmine": "~1.1.0",
"karma-jasmine-html-reporter": "^0.2.2",
"karma-coverage-istanbul-reporter": "^0.2.0",
"protractor": "~5.1.0",
"ts-node": "~2.0.0",
"tslint": "~4.5.0",
"typescript": "~2.2.0"
"name": "Burger King",
"location": "The Johnson Center",
"date_modified": "2015-08-31T16:52:09.600Z",
"phone_number": "703-121-3212",
"tap_n_go_link": "",
"tags": ["vegan", "mexican"],
"address": "4335 Chesapeake River Way Fairfax, Virginia",
"geojson": {
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [125.6, 10.1]
"properties": {
"name": "Dinagat Islands"
"operation_hours": [{
"special_status": false,
"is_closed": false,
"open_all_day": false,
"open_time": [9, 40],
"close_time": [14, 30]
"special_status": "Closed for Construction",
"is_closed": true,
"open_all_day": false,
"open_time": false,
"close_time": false
"special_status": false,
"is_closed": false,
"open_all_day": true,
"open_time": false,
"close_time": false
"special_status": false,
"is_closed": false,
"open_all_day": false,
"open_time": [9, 40],
"close_time": [14, 30]
"special_status": false,
"is_closed": false,
"open_all_day": false,
"open_time": [9, 40],
"close_time": [14, 30]
"special_status": false,
"is_closed": false,
"open_all_day": false,
"open_time": [9, 40],
"close_time": [14, 30]
"special_status": false,
"is_closed": false,
"open_all_day": false,
"open_time": [9, 40],
"close_time": [14, 30]