From ef23d13be27e43fb72eb69c0e829b6d831771722 Mon Sep 17 00:00:00 2001
From: Daniel W Bond <dbond2@gmu.edu>
Date: Sat, 16 Jan 2016 11:48:10 -0500
Subject: [PATCH] added additional print statement logging and try/except's for
 the user creation callback

---
 bookshare/core/cas_callbacks.py | 130 +++++++++++++++++++-------------
 1 file changed, 77 insertions(+), 53 deletions(-)

diff --git a/bookshare/core/cas_callbacks.py b/bookshare/core/cas_callbacks.py
index 2309669..875ce77 100644
--- a/bookshare/core/cas_callbacks.py
+++ b/bookshare/core/cas_callbacks.py
@@ -1,53 +1,77 @@
-# core django imports
-from django.conf import settings
-from django.contrib.auth.models import User
-# third-part imports
-import requests
-# imports from your apps
-from django.conf import settings
-from .models import Student
-
-
-def pfinfo(u_name):
-    pf_url = settings.PF_URL
-    url = str(pf_url) + "basic/all/" + str(u_name)
-    try:
-        metadata = requests.get(url)
-        metadata.raise_for_status()
-    except requests.exceptions.RequestException as e:
-        print e
-    else:
-        pf_json = metadata.json()
-        try:
-            name = pf_json['results'][0]['name']
-            return name.split(',')
-        # if the name is not in peoplefinder, return empty first and last name
-        except IndexError:
-            return ['', '']
-
-
-def create_user(tree):
-    username = tree[0][0].text
-    print username
-    user, user_created = User.objects.get_or_create(username=username)
-
-    if user_created:
-        user.email = "%s@%s" % (username, settings.ORGANIZATION_EMAIL_DOMAIN)
-        print "hello"
-        name_list = pfinfo(str(username))
-        print name_list, "name_list"
-        first_name = name_list[1].lstrip().split(' ')
-        if len(first_name) > 1:
-            no_mi = first_name[:-1]
-            user.first_name = ' '.join(no_mi)
-        else:
-            user.first_name = ' '.join(first_name)
-        last_name = name_list[0]
-        user.last_name = name_list[0]
-
-        print "world"
-        user.save()
-        new_student = Student.objects.create(user=user)
-        new_student.save()
-
-        print("Created user %s!" % username)
+# standard library imports
+from __future__ import absolute_import, print_function
+# core django imports
+from django.conf import settings
+from django.contrib.auth.models import User
+from django.conf import settings
+from django.core.exceptions import ObjectDoesNotExist
+# third-part imports
+import requests
+# imports from your apps
+from .models import Student
+
+
+def pfinfo(u_name):
+    pf_url = settings.PF_URL
+    url = str(pf_url) + "basic/all/" + str(u_name)
+    try:
+        metadata = requests.get(url, timeout=5)
+        print("Retrieving information from the peoplefinder api.")
+        metadata.raise_for_status()
+    except requests.exceptions.RequestException as e:
+        print("Cannot resolve to peoplefinder api:" , e)
+    else:
+        try:
+            pf_json = metadata.json()
+            name = pf_json['results'][0]['name']
+            return name.split(',')
+        # if the name is not in peoplefinder, return empty first and last name
+        except IndexError:
+            return ['', '']
+
+
+def create_user(tree):
+
+    print("Parsing CAS information.")
+    try:
+        username = tree[0][0].text
+        user, user_created = User.objects.get_or_create(username=username)
+
+        if user_created:
+            print("Created user object %s." % username)
+            user.email = "%s@%s" % (username, settings.ORGANIZATION_EMAIL_DOMAIN)
+            user.set_password('cas_used_instead')
+
+            try:
+                name_list = pfinfo(str(username))
+                first_name = name_list[1].lstrip().split(' ')
+                if len(first_name) > 1:
+                    no_mi = first_name[:-1]  # no middle initial
+                    user.first_name = ' '.join(no_mi)
+                else:
+                    user.first_name = ' '.join(first_name)
+                last_name = name_list[0]
+                user.last_name = name_list[0]
+                print("Added user's name, %s %s." % first_name, last_name)
+            except:
+                print("Problem setting user's name via peoplefinder.")
+
+            user.save()
+            print("User object creation completed.")
+
+        else:
+            print("User object already exists.")
+
+        try:
+            Student.objects.get(user=user)
+            print("Student object already exists.")
+        except ObjectDoesNotExist:
+            new_student = Student.objects.create(user=user)
+            new_student.save()
+            print("Student object creation completed.")
+
+        print("CAS callback successful.")
+
+    except Exception as e:
+        print("Unhandled user creation error:", e)
+        # mail the administrators
-- 
GitLab