GitLab

This commit updates the yarn lockfile and the package json to the up to
date items.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit makes the tests on the Formattype isregname a bit more
intuitive and way less confusing. By using a forEach and constructing
each case instead of manually typing it it is now way simpler to add
tests as well.
Signed-off-by: Mark Stenglein <mark@stengle.in>

Parameter: FormatType: Adds FormatType and tests

Closes #5 

This commit adds the format type parameter type.

Moving forward, there are a couple of todo items that should be
addressed at some point in the future.
Signed-off-by: Mark Stenglein <mark@stengle.in>

Parameters: Encoding: add Encoding Param type
Closes #4

This commit adds the entire Encoding Parameter Type along with it's
associated test cases. See #4

.
Signed-off-by: Mark Stenglein <mark@stengle.in>

Parameters: organize parameters into directory

This commit moves all the parameters and their test cases to make it so
they are not a jumbled mess of files as they were before.
Signed-off-by: Mark Stenglein <mark@stengle.in>

3 dir entry ref

Closes #3

Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit adds in the implementation for RFC5545's chapter 3.2.6.

Moving forward, there are two TODO's that should be considered:

  1. When the CAL-ADDRESS type is implemented, there needs to be
  something added to this and other classes like it that enforce the
  restriction on which content line types are allowed to possess this
  parameter type.

  2. When this project is able to be ported over in such a way that it
  can be browser packaged, there might be an issue with using the NodeJS
  implemented URL class. I'm not sure about if it will work or not, but
  future me looking at git blames for why it is not working should take
  some direction from this message. Keep going, future me, keep going!
Signed-off-by: Mark Stenglein <mark@stengle.in>

The DirectoryEntryReference class requires the use of the URL class,
which is provided by node.js. For this to work, I need the TypeScript
typings as well.

This commit adds the package both the `package.json` and the yarn
lockfile.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit finishes describing what the class is supposed to be
according to the RFC document.
Signed-off-by: Mark Stenglein <mark@stengle.in>

Simply updates npm dependencies
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit adds Yarn to the project stack. Don't I feel hip now that
I'm developing with the cool cats?
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit adds Yarn to the project stack. Don't I feel hip now that
I'm developing with the cool cats?
Signed-off-by: Mark Stenglein <mark@stengle.in>

* DelegateesParam: Add bare minimum class and comments

This commit adds the DelegateesParam parameter to the repo. The Param
actually does nothing at the moment but I intend to change that.

Additionally a test class is birthed alongside this parameter that
checks the existence of the file. Important stuff.
Signed-off-by: David Haynes <dhaynes3@gmu.edu>

* DelegateesParam: Complete comments defining DelegateesParam

Essentially a big copy paste from the RFC. It's really helpful that
DelegatorsParam is so similar.
Signed-off-by: David Haynes <dhaynes207@gmail.com>

* DelegateesParam: Complete first pass on implementation

Delegatees function identically to delegators though have some slight
verbage changes. As a result borrow everything from DelegatorParam but
modify where needed.

Implement test spec to verify implementaion.

Closes #2

Signed-off-by: David Haynes <dhaynes207@gmail.com>

* DelegateesParam: whitespace fixes

This commit fixes whitespace on a couple of the files introduced in !20
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit starts the new directory entry reference parameter type.

This commit also adds the starting test suite, and tests to make sure
the class isn't deleted by somebody on accident.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit refactors the setter in AltRepParam's uri value to use
string templates instead of using string concatenation.

Take two.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This reverts commit f08cc51a

.

Run the test cases. Run them before committing. Run. The. Tests.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit refactors the setter in AltRepParam's uri value to use
string templates instead of using string concatenation.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit refactors the `isXName` and `isQuotedString` static methods
to avoid unneeded usage of single use varables for tracking the
pass/fail status.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit refactors the paramValues setter to use Array.every and
avoid the performance hit from using forEach.

This commit also adds the isParamValue static validator to the Parameter
class. This is used by the Array.every call, and should probably be
moved eventually to a validator class that should also be built.
Signed-off-by: Mark Stenglein <mark@stengle.in>

Eliminates a huge amount of code in favor of one template string. Should
work much better.

Additionally, there was a mistake in the test cases where the CRLF was
omitted from the test. This commit fixes that by simply adding it.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit makes one more minor change to remove one more single use
variable that really isn't neccessary.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit refactors the setter in DelegatorsParam so that it uses a
more understandable code style.

Replacing the foreach with a single if statement which uses Array.every,
and then using Array.map as well as a prepared string to make the
paramValues for the generator function.
Reported-by: Akshay Karthik <akshay.karthik@gmail.com>
Signed-off-by: Mark Stenglein <mark@stengle.in>

Adds in the Delegators Parameter from RFC 5545 section 3.2.4.

There are a couple TODO's left behind for when I get to later sections
of the RFC. It doesn't make sense to work out an implementation until
I'm working on those actual features that will use it.
Signed-off-by: Mark Stenglein <mark@stengle.in>

I know I told @rhitt

 I don't use the backspace key, and instead write
perfect code, but this was super awkward.

This commit eliminates an unneeded boolean flag variable as well as some
hacky control structures by throwing the exception when the problem is
detected instead of waiting.

As a bonus, this should help increase speed when dealing with longer
lists of parameter values where one may be invalid.
Signed-off-by: Mark Stenglein <mark@stengle.in>

There was an issue where the entire test suite would bail after one
specfile fails. That is not useful.

This commit fixes the issue by simply removing the `--bail` flag from
the npm test script.
Signed-off-by: Mark Stenglein <mark@stengle.in>

This commit along with the previous commits implements
the Delegator Parameter sufficiently to move on.

There are still a couple of TODO's out for this one,
but for the most part it's all ++ and the test cases are
successful.

When this gets to the point where I have implemented the
different CAL-ADDRESS value type, I'll need to come back to this
and figure out how to implement that TODO.
Signed-off-by: Mark Stenglein <mark@stengle.in>

NPM was throwing an error, this fixes it.
Signed-off-by: Mark Stenglein <mark@stengle.in>

More work is still needed here to finish out the spec, mainly
 in enforcing some validations. Check the todo's for the bulk of
 it.

tl;dr: I've been up for more than 24 hours and need to go to bed,
    so here's my commit of progress :)
Signed-off-by: Mark Stenglein <mark@stengle.in>

Signed-off-by: Mark Stenglein <mark@stengle.in>

This has been needed. Here it is.
Signed-off-by: Mark Stenglein <mark@stengle.in>

Signed-off-by: Mark Stenglein <mark@stengle.in>

Adds the missing documentation to the DelegatorsParam file.
Signed-off-by: Mark Stenglein <mark@stengle.in>

Signed-off-by: Mark Stenglein <mark@stengle.in>

Signed-off-by: Mark Stenglein <mark@stengle.in>

Signed-off-by: Mark Stenglein <mark@stengle.in>

should really have tested that last one
Signed-off-by: Mark Stenglein <mark@stengle.in>