Ensure btn-outline colors remain the same in <a>

- specifically, if a href= is missing then ensure the styling persists

Ensure btn-outline colors remain the same in <a>
- specifically, if a href= is missing then ensure the styling persists
35432916 · David Haynes · fc22f5a2 · 35432916 · 35432916
Verified Commit 35432916 authored Dec 21, 2017 by David Haynes 🙆
Hide whitespace changes
Inline Side-by-side

Showing with 24 additions and 9 deletions

src/html/demo.html src/html/demo.html +7 -4

src/scss/_overwrites.scss src/scss/_overwrites.scss +17 -5

No files found.
--- a/src/html/demo.html
+++ b/src/html/demo.html
@@ -32,7 +32,7 @@

    <!-- Load in static content -->
    <link rel="icon" href="./img/favicon.ico" sizes="16x16">
-    <link rel="stylesheet" href="./css/masonstrap.min.css" media="screen">
+    <link rel="stylesheet" href="./css/masonstrap.css" media="screen">
  </head>

  <!-- Navbar -->
@@ -65,6 +65,11 @@
    </div>
  </nav>

+
+  <body>
+    <a class="btn btn-outline-primary">Download</a>
+  </body>
+
  <!-- Footer -->
  <footer class="footer">
    <div class="container">
@@ -73,8 +78,6 @@
  </footer>

  <!-- load in external js -->
-  <script src="./js/jquery.min.js"></script>
-  <script src="./js/popper.min.js"></script>
-  <script src="./js/bootstrap.min.js"></script>
+  <script src="./js/masonstrap.min.js"></script>

 </html>
\ No newline at end of file
--- a/src/scss/_overwrites.scss
+++ b/src/scss/_overwrites.scss
 // Things that originate from Bootstrap that we overwrite

+// Legacy legend behavior
 legend {
-    @extend legend;
-    margin-top: 1rem;
-    margin-bottom: 1rem;
-    border: 0;
-    border-bottom: 1px solid rgba(0,0,0,0.1)
+  @extend legend;
+  margin-top: 1rem;
+  margin-bottom: 1rem;
+  border: 0;
+  border-bottom: 1px solid rgba(0, 0, 0, 0.1)
+}
+
+// Ensure btn-outline colors remain the same even if there is no href 
+@each $color, $value in $theme-colors {
+  a.btn-outline-#{$color}:not([href]) {
+    color: $value;   
+  }
+
+  a.btn-outline-#{$color}:not([href]):hover {
+    color: $white;   
+  }
 }
\ No newline at end of file