Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • schedules schedules
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SRCT
  • schedulesschedules
  • Issues
  • #34

Closed
Open
Created Jan 23, 2019 by Zac Wood@zwood2Owner

Make "share" link an actual link

Summary

The "share" link on the Schedule page is currently a <code> element instead of an <a> element. This means users can't click on the link directly; they must manually copy and paste if they want to share it. This is bad.

Change the element to an <a> and update the JavaScript function that sets the URL.

Helpful Links

The element itself is located at https://git.gmu.edu/srct/schedules/blob/master/schedules/app/views/schedules/show.html.erb#L37

The JavaScript function is located at https://git.gmu.edu/srct/schedules/blob/master/schedules/app/javascript/packs/schedules.js#L39. This will need to be updated to change the href attribute on the element instead of just setting the innerText property as it does now.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking