Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • whats-open-android whats-open-android
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SRCT
  • whats-open-androidwhats-open-android
  • Issues
  • #29

Closed
Open
Created Oct 25, 2017 by Robert Hitt@rhittOwner

Remove Unnecessary Date Parsing

Summary

Currently, the MainPresenter unnecessarily parses time strings into Date objects. For some reason I thought this was necessary to compare them, but upon second thought it might not be that necessary. So, in all places in MainPresenter.java, sdf.parse() should be removed.

e.g. Date startTime = sdf.parse(currentOpenTimes.getStartTime()); should be changed to String startTime = currentOpenTimes.getStartTime();

Also, after everything is removed, all tests should be run to make sure nothing is busted.

Helpful Links

  • https://developer.android.com/training/testing/unit-testing/local-unit-tests.html#run for running tests
Assignee
Assign to
Time tracking